Fix the issue with replacing old Timeline visual with newer version #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set.
MulyukovAidar
approved these changes
Jan 25, 2024
MulyukovAidar
added a commit
that referenced
this pull request
Jun 10, 2024
* Update timeline to use new formatting model API (5.1+) (#137) * Add new formatting model units * Update capabilities.json to new formatting model API * Update version to 2.5.0 * Refactor Calendar into using interfaces * Upgrade to new formatting model API * Remove jquery, fix tests * Migrate from puppeteer to playwright-chromium * Split d3 into submodules like d3-selection * Update dependencies Previously visual didn't work with node v20.10.0, but after updating the dependencies it works now. * Set default value "false" for ScrollAutoAdjustment * Fix top level slices to display "show" button on the cards * Add stroke color and stroke width settings * Add cursor color settings * Add an option to specify the width, height manually * Add scroll behavior When scrolling on the cell it increases/decreases the date period. * Add cell gap setting * Revert "Add scroll behavior" This reverts commit 3a0e970. * Decrease min cell width. Add missing localization keys. * Fix build status in README.md * Use 4 digit number in version * Update build.yml to run audit, outdated, linter * Rename ambiguous topLevelSlice to show field. Revert MinCellWidth to fix a breaking change. * Fix the resizing issue when enabling manual sizing. When enabling manual sizing width and height of the cell is changed to the last saved by the user. Instead, the expected behavior is so width and height should be the same as before enabling manual sizing. It requires persisting current width and height of cells, but it triggers an additional update. * Fix uneven stroke width around cells When increasing stroke-width around the cells the height of the cell should be decreasing, otherwise the stroke is uneven. * Fix vertical cursor shift when changing stroke width * Update packages * Fix npm vulnerabilities * Remove core-js * Update powerbi-visuals-api to 5.7.0 * Fix the issue with replacing old Timeline visual with newer version (#138) * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Fix the issue with upgrading the visual version inside the report When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set. * Fix eslint errors * New translations * Fix error with rendering when ItemDropDown values are undefined (#139) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * New translations * Fix backwards compatibility (#143) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Set topLevelSlice for "Cursor", "First Day of Week" formatting settings cards * Update API to 5.8.0 * Fix height and width calculation when enableManualSizing is enabled * Limit max text size in range header and labels * Rollback capabilities.json to previous configuration to keep backwards compatibility * Update packages Bump version to 2.5.0.0 * Remove jquery * Update GitHub actions to use node 18, 20 * Add TimelineSettingsModel.ts * Refactor calendar interfaces * Migrate to formatting model * Add visual short and long description localization keys * Fix granularity value backwards compatibility (use numbers instead of string) * Add cursor formatting settings * Add "Cells" card settings: stroke width and gap width * Add formatting setting to manually resize cell height and width * Split D3 into submodules like d3-selection * Update packages * Update API to 5.9.0 * Refactor event handlers into behavior.ts * Refactor behavior.ts into static * Fix karma.config * Fix bugs with click handler and selecting period (#148) * Disable "Calendar" and "First day of week" settings when WeekStandard is set to IS0 8601 * Fix cell click handler (passed invalid selected index) * Fix uninitialized start date when date from filters is less than date from DataView * Increase font max size for range header to 40 * Update outdated packages * New translations * New translations * New translations --------- Co-authored-by: adiletelf <[email protected]> Co-authored-by: pbicvloc <[email protected]>
MulyukovAidar
added a commit
that referenced
this pull request
Jun 10, 2024
* New translations (#112) * Microsoft mandatory file (#117) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * Update codeql-analysis.yml * Dev (#153) * Update timeline to use new formatting model API (5.1+) (#137) * Add new formatting model units * Update capabilities.json to new formatting model API * Update version to 2.5.0 * Refactor Calendar into using interfaces * Upgrade to new formatting model API * Remove jquery, fix tests * Migrate from puppeteer to playwright-chromium * Split d3 into submodules like d3-selection * Update dependencies Previously visual didn't work with node v20.10.0, but after updating the dependencies it works now. * Set default value "false" for ScrollAutoAdjustment * Fix top level slices to display "show" button on the cards * Add stroke color and stroke width settings * Add cursor color settings * Add an option to specify the width, height manually * Add scroll behavior When scrolling on the cell it increases/decreases the date period. * Add cell gap setting * Revert "Add scroll behavior" This reverts commit 3a0e970. * Decrease min cell width. Add missing localization keys. * Fix build status in README.md * Use 4 digit number in version * Update build.yml to run audit, outdated, linter * Rename ambiguous topLevelSlice to show field. Revert MinCellWidth to fix a breaking change. * Fix the resizing issue when enabling manual sizing. When enabling manual sizing width and height of the cell is changed to the last saved by the user. Instead, the expected behavior is so width and height should be the same as before enabling manual sizing. It requires persisting current width and height of cells, but it triggers an additional update. * Fix uneven stroke width around cells When increasing stroke-width around the cells the height of the cell should be decreasing, otherwise the stroke is uneven. * Fix vertical cursor shift when changing stroke width * Update packages * Fix npm vulnerabilities * Remove core-js * Update powerbi-visuals-api to 5.7.0 * Fix the issue with replacing old Timeline visual with newer version (#138) * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Fix the issue with upgrading the visual version inside the report When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set. * Fix eslint errors * New translations * Fix error with rendering when ItemDropDown values are undefined (#139) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * New translations * Fix backwards compatibility (#143) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Set topLevelSlice for "Cursor", "First Day of Week" formatting settings cards * Update API to 5.8.0 * Fix height and width calculation when enableManualSizing is enabled * Limit max text size in range header and labels * Rollback capabilities.json to previous configuration to keep backwards compatibility * Update packages Bump version to 2.5.0.0 * Remove jquery * Update GitHub actions to use node 18, 20 * Add TimelineSettingsModel.ts * Refactor calendar interfaces * Migrate to formatting model * Add visual short and long description localization keys * Fix granularity value backwards compatibility (use numbers instead of string) * Add cursor formatting settings * Add "Cells" card settings: stroke width and gap width * Add formatting setting to manually resize cell height and width * Split D3 into submodules like d3-selection * Update packages * Update API to 5.9.0 * Refactor event handlers into behavior.ts * Refactor behavior.ts into static * Fix karma.config * Fix bugs with click handler and selecting period (#148) * Disable "Calendar" and "First day of week" settings when WeekStandard is set to IS0 8601 * Fix cell click handler (passed invalid selected index) * Fix uninitialized start date when date from filters is less than date from DataView * Increase font max size for range header to 40 * Update outdated packages * New translations * New translations * New translations --------- Co-authored-by: adiletelf <[email protected]> Co-authored-by: pbicvloc <[email protected]> --------- Co-authored-by: pbicvloc <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: adiletelf <[email protected]>
Demonkratiy
pushed a commit
that referenced
this pull request
Aug 13, 2024
* New translations (#112) * Microsoft mandatory file (#117) * Update codeql-analysis.yml * Dev (#153) * Update timeline to use new formatting model API (5.1+) (#137) * Add new formatting model units * Update capabilities.json to new formatting model API * Update version to 2.5.0 * Refactor Calendar into using interfaces * Upgrade to new formatting model API * Remove jquery, fix tests * Migrate from puppeteer to playwright-chromium * Split d3 into submodules like d3-selection * Update dependencies Previously visual didn't work with node v20.10.0, but after updating the dependencies it works now. * Set default value "false" for ScrollAutoAdjustment * Fix top level slices to display "show" button on the cards * Add stroke color and stroke width settings * Add cursor color settings * Add an option to specify the width, height manually * Add scroll behavior When scrolling on the cell it increases/decreases the date period. * Add cell gap setting * Revert "Add scroll behavior" This reverts commit 3a0e970. * Decrease min cell width. Add missing localization keys. * Fix build status in README.md * Use 4 digit number in version * Update build.yml to run audit, outdated, linter * Rename ambiguous topLevelSlice to show field. Revert MinCellWidth to fix a breaking change. * Fix the resizing issue when enabling manual sizing. When enabling manual sizing width and height of the cell is changed to the last saved by the user. Instead, the expected behavior is so width and height should be the same as before enabling manual sizing. It requires persisting current width and height of cells, but it triggers an additional update. * Fix uneven stroke width around cells When increasing stroke-width around the cells the height of the cell should be decreasing, otherwise the stroke is uneven. * Fix vertical cursor shift when changing stroke width * Update packages * Fix npm vulnerabilities * Remove core-js * Update powerbi-visuals-api to 5.7.0 * Fix the issue with replacing old Timeline visual with newer version (#138) * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Fix the issue with upgrading the visual version inside the report When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set. * Fix eslint errors * New translations * Fix error with rendering when ItemDropDown values are undefined (#139) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * New translations * Fix backwards compatibility (#143) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Set topLevelSlice for "Cursor", "First Day of Week" formatting settings cards * Update API to 5.8.0 * Fix height and width calculation when enableManualSizing is enabled * Limit max text size in range header and labels * Rollback capabilities.json to previous configuration to keep backwards compatibility * Update packages Bump version to 2.5.0.0 * Remove jquery * Update GitHub actions to use node 18, 20 * Add TimelineSettingsModel.ts * Refactor calendar interfaces * Migrate to formatting model * Add visual short and long description localization keys * Fix granularity value backwards compatibility (use numbers instead of string) * Add cursor formatting settings * Add "Cells" card settings: stroke width and gap width * Add formatting setting to manually resize cell height and width * Split D3 into submodules like d3-selection * Update packages * Update API to 5.9.0 * Refactor event handlers into behavior.ts * Refactor behavior.ts into static * Fix karma.config * Fix bugs with click handler and selecting period (#148) * Disable "Calendar" and "First day of week" settings when WeekStandard is set to IS0 8601 * Fix cell click handler (passed invalid selected index) * Fix uninitialized start date when date from filters is less than date from DataView * Increase font max size for range header to 40 * Update outdated packages * New translations * New translations * New translations --------- --------- Co-authored-by: MulyukovAidar <[email protected]> Co-authored-by: pbicvloc <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Demonkratiy
pushed a commit
that referenced
this pull request
Aug 13, 2024
* New translations (#112) * Microsoft mandatory file (#117) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * Update timeline to use new formatting model API (5.1+) (#137) * Add new formatting model units * Update capabilities.json to new formatting model API * Update version to 2.5.0 * Refactor Calendar into using interfaces * Upgrade to new formatting model API * Remove jquery, fix tests * Migrate from puppeteer to playwright-chromium * Split d3 into submodules like d3-selection * Update dependencies Previously visual didn't work with node v20.10.0, but after updating the dependencies it works now. * Set default value "false" for ScrollAutoAdjustment * Fix top level slices to display "show" button on the cards * Add stroke color and stroke width settings * Add cursor color settings * Add an option to specify the width, height manually * Add scroll behavior When scrolling on the cell it increases/decreases the date period. * Add cell gap setting * Revert "Add scroll behavior" This reverts commit 3a0e970. * Decrease min cell width. Add missing localization keys. * Fix build status in README.md * Use 4 digit number in version * Update build.yml to run audit, outdated, linter * Rename ambiguous topLevelSlice to show field. Revert MinCellWidth to fix a breaking change. * Fix the resizing issue when enabling manual sizing. When enabling manual sizing width and height of the cell is changed to the last saved by the user. Instead, the expected behavior is so width and height should be the same as before enabling manual sizing. It requires persisting current width and height of cells, but it triggers an additional update. * Fix uneven stroke width around cells When increasing stroke-width around the cells the height of the cell should be decreasing, otherwise the stroke is uneven. * Fix vertical cursor shift when changing stroke width * Update packages * Fix npm vulnerabilities * Remove core-js * Update powerbi-visuals-api to 5.7.0 * Fix the issue with replacing old Timeline visual with newer version (#138) * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Fix the issue with upgrading the visual version inside the report When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set. * Fix eslint errors * New translations * Fix error with rendering when ItemDropDown values are undefined (#139) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Update codeql-analysis.yml * New translations * Fix backwards compatibility (#143) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Set topLevelSlice for "Cursor", "First Day of Week" formatting settings cards * Update API to 5.8.0 * Fix height and width calculation when enableManualSizing is enabled * Limit max text size in range header and labels * Rollback capabilities.json to previous configuration to keep backwards compatibility * Update packages Bump version to 2.5.0.0 * Remove jquery * Update GitHub actions to use node 18, 20 * Add TimelineSettingsModel.ts * Refactor calendar interfaces * Migrate to formatting model * Add visual short and long description localization keys * Fix granularity value backwards compatibility (use numbers instead of string) * Add cursor formatting settings * Add "Cells" card settings: stroke width and gap width * Add formatting setting to manually resize cell height and width * Split D3 into submodules like d3-selection * Update packages * Update API to 5.9.0 * Refactor event handlers into behavior.ts * Refactor behavior.ts into static * Fix karma.config * Fix bugs with click handler and selecting period (#148) * Disable "Calendar" and "First day of week" settings when WeekStandard is set to IS0 8601 * Fix cell click handler (passed invalid selected index) * Fix uninitialized start date when date from filters is less than date from DataView * Increase font max size for range header to 40 * Update outdated packages * New translations * New translations * New translations * Add toggle 'Treat as end of fiscal year' (#150) * Add toggle 'Treat as end of fiscal year' * Disable 'Force selection' toggles when filters are changed * Fix 'Force selection' update on filter change * Update packages, bump version to 2.5.6.0 * Fix selecting current period * Fix npm vulnerabilities * Fix forceSelection update when currentPeriod dates is null * Add labels toggle switches to allow users to customize which labels to show * Fix week granularity label Previously it showed 'Year 5 - 2014, Q1 Jan' instead of 'Week 5 - 2014, Q1 Jan' * Fix rendering visual when scroll is enabled. Fix scroll arrows not being clicked * Remove range header font size restrictions * Remove displayAll from labels * Remove tests with label 'displayAll' * Downgrade to API 5.9.0 (#155) * New translations --------- Co-authored-by: pbicvloc <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: MulyukovAidar <[email protected]>
Demonkratiy
added a commit
that referenced
this pull request
Sep 2, 2024
* New translations (#112) * Microsoft mandatory file (#117) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * Update timeline to use new formatting model API (5.1+) (#137) * Add new formatting model units * Update capabilities.json to new formatting model API * Update version to 2.5.0 * Refactor Calendar into using interfaces * Upgrade to new formatting model API * Remove jquery, fix tests * Migrate from puppeteer to playwright-chromium * Split d3 into submodules like d3-selection * Update dependencies Previously visual didn't work with node v20.10.0, but after updating the dependencies it works now. * Set default value "false" for ScrollAutoAdjustment * Fix top level slices to display "show" button on the cards * Add stroke color and stroke width settings * Add cursor color settings * Add an option to specify the width, height manually * Add scroll behavior When scrolling on the cell it increases/decreases the date period. * Add cell gap setting * Revert "Add scroll behavior" This reverts commit 3a0e970. * Decrease min cell width. Add missing localization keys. * Fix build status in README.md * Use 4 digit number in version * Update build.yml to run audit, outdated, linter * Rename ambiguous topLevelSlice to show field. Revert MinCellWidth to fix a breaking change. * Fix the resizing issue when enabling manual sizing. When enabling manual sizing width and height of the cell is changed to the last saved by the user. Instead, the expected behavior is so width and height should be the same as before enabling manual sizing. It requires persisting current width and height of cells, but it triggers an additional update. * Fix uneven stroke width around cells When increasing stroke-width around the cells the height of the cell should be decreasing, otherwise the stroke is uneven. * Fix vertical cursor shift when changing stroke width * Update packages * Fix npm vulnerabilities * Remove core-js * Update powerbi-visuals-api to 5.7.0 * Fix the issue with replacing old Timeline visual with newer version (#138) * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Fix the issue with upgrading the visual version inside the report When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set. * Fix eslint errors * New translations * Fix error with rendering when ItemDropDown values are undefined (#139) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Update codeql-analysis.yml * New translations * Fix backwards compatibility (#143) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Set topLevelSlice for "Cursor", "First Day of Week" formatting settings cards * Update API to 5.8.0 * Fix height and width calculation when enableManualSizing is enabled * Limit max text size in range header and labels * Rollback capabilities.json to previous configuration to keep backwards compatibility * Update packages Bump version to 2.5.0.0 * Remove jquery * Update GitHub actions to use node 18, 20 * Add TimelineSettingsModel.ts * Refactor calendar interfaces * Migrate to formatting model * Add visual short and long description localization keys * Fix granularity value backwards compatibility (use numbers instead of string) * Add cursor formatting settings * Add "Cells" card settings: stroke width and gap width * Add formatting setting to manually resize cell height and width * Split D3 into submodules like d3-selection * Update packages * Update API to 5.9.0 * Refactor event handlers into behavior.ts * Refactor behavior.ts into static * Fix karma.config * Fix bugs with click handler and selecting period (#148) * Disable "Calendar" and "First day of week" settings when WeekStandard is set to IS0 8601 * Fix cell click handler (passed invalid selected index) * Fix uninitialized start date when date from filters is less than date from DataView * Increase font max size for range header to 40 * Update outdated packages * New translations * New translations * New translations * Add toggle 'Treat as end of fiscal year' (#150) * Add toggle 'Treat as end of fiscal year' * Disable 'Force selection' toggles when filters are changed * Fix 'Force selection' update on filter change * Update packages, bump version to 2.5.6.0 * Fix selecting current period * Fix npm vulnerabilities * Fix forceSelection update when currentPeriod dates is null * Add labels toggle switches to allow users to customize which labels to show * Fix week granularity label Previously it showed 'Year 5 - 2014, Q1 Jan' instead of 'Week 5 - 2014, Q1 Jan' * Fix rendering visual when scroll is enabled. Fix scroll arrows not being clicked * Remove range header font size restrictions * Remove displayAll from labels * Remove tests with label 'displayAll' * Downgrade to API 5.9.0 (#155) * New translations * updating certification branch (#154) (#158) * New translations (#112) * Microsoft mandatory file (#117) * Update codeql-analysis.yml * Dev (#153) * Update timeline to use new formatting model API (5.1+) (#137) * Add new formatting model units * Update capabilities.json to new formatting model API * Update version to 2.5.0 * Refactor Calendar into using interfaces * Upgrade to new formatting model API * Remove jquery, fix tests * Migrate from puppeteer to playwright-chromium * Split d3 into submodules like d3-selection * Update dependencies Previously visual didn't work with node v20.10.0, but after updating the dependencies it works now. * Set default value "false" for ScrollAutoAdjustment * Fix top level slices to display "show" button on the cards * Add stroke color and stroke width settings * Add cursor color settings * Add an option to specify the width, height manually * Add scroll behavior When scrolling on the cell it increases/decreases the date period. * Add cell gap setting * Revert "Add scroll behavior" This reverts commit 3a0e970. * Decrease min cell width. Add missing localization keys. * Fix build status in README.md * Use 4 digit number in version * Update build.yml to run audit, outdated, linter * Rename ambiguous topLevelSlice to show field. Revert MinCellWidth to fix a breaking change. * Fix the resizing issue when enabling manual sizing. When enabling manual sizing width and height of the cell is changed to the last saved by the user. Instead, the expected behavior is so width and height should be the same as before enabling manual sizing. It requires persisting current width and height of cells, but it triggers an additional update. * Fix uneven stroke width around cells When increasing stroke-width around the cells the height of the cell should be decreasing, otherwise the stroke is uneven. * Fix vertical cursor shift when changing stroke width * Update packages * Fix npm vulnerabilities * Remove core-js * Update powerbi-visuals-api to 5.7.0 * Fix the issue with replacing old Timeline visual with newer version (#138) * Add "Visual_Short_Description", "Visual_Long_Description" localization keys * Fix the issue with upgrading the visual version inside the report When user replaces the visual with new version the visual didn't render because some ItemDropDown values were not set. * Fix eslint errors * New translations * Fix error with rendering when ItemDropDown values are undefined (#139) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * New translations * Fix backwards compatibility (#143) * Fix error with rendering when ItemDropDown values are undefined * Fix tests * Set topLevelSlice for "Cursor", "First Day of Week" formatting settings cards * Update API to 5.8.0 * Fix height and width calculation when enableManualSizing is enabled * Limit max text size in range header and labels * Rollback capabilities.json to previous configuration to keep backwards compatibility * Update packages Bump version to 2.5.0.0 * Remove jquery * Update GitHub actions to use node 18, 20 * Add TimelineSettingsModel.ts * Refactor calendar interfaces * Migrate to formatting model * Add visual short and long description localization keys * Fix granularity value backwards compatibility (use numbers instead of string) * Add cursor formatting settings * Add "Cells" card settings: stroke width and gap width * Add formatting setting to manually resize cell height and width * Split D3 into submodules like d3-selection * Update packages * Update API to 5.9.0 * Refactor event handlers into behavior.ts * Refactor behavior.ts into static * Fix karma.config * Fix bugs with click handler and selecting period (#148) * Disable "Calendar" and "First day of week" settings when WeekStandard is set to IS0 8601 * Fix cell click handler (passed invalid selected index) * Fix uninitialized start date when date from filters is less than date from DataView * Increase font max size for range header to 40 * Update outdated packages * New translations * New translations * New translations --------- --------- Co-authored-by: MulyukovAidar <[email protected]> Co-authored-by: pbicvloc <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * Fix the bug with dragging cursors (#160) --------- Co-authored-by: pbicvloc <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: adiletelf <[email protected]> Co-authored-by: MulyukovAidar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.