Display numbers issue (#21)

* Fix scale settings text.
* Fix displaying visual with numbers
* Downgrade API version to 1.6.0

CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.2.7
+
+* Fix scale settings text.
+* Fix displaying the visual with numeric at Source and Destination fields
+* Downgrade API version to 1.6.0
+
 ## 1.2.5
 
 * Fix selection issue for cloned nodes in dataset with cycles

capabilities.json

@@ -53,20 +53,6 @@
                     },
                     "Weight": {
                         "min": 0,
-                        "max": 0
-                    }
-                },
-                {
-                    "Source": {
-                        "min": 0,
-                        "max": 1
-                    },
-                    "Destination": {
-                        "min": 0,
-                        "max": 1
-                    },
-                    "Weight": {
-                        "min": 1,
                         "max": 1
                     }
                 }
@@ -184,7 +170,7 @@
             }
         },
         "scaleSettings": {
-            "displayName": "Scale settings",
+            "displayName": "Enable logarithmic scale",
             "displayNameKey": "Visual_ScaleSettings",
             "properties": {
                 "show": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-sankey",
-  "version": "1.2.5",
+  "version": "1.2.7",
   "description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow.  Use it to find major contributions to an overall flow.",
   "repository": {
     "type": "git",
@@ -10,7 +10,7 @@
     "powerbi-visuals"
   ],
   "scripts": {
-    "postinstall": "pbiviz update 1.7.0",
+    "postinstall": "pbiviz update 1.6.0",
     "typings": "typings",
     "pbiviz": "pbiviz",
     "start": "pbiviz start",

pbiviz.json

@@ -4,12 +4,12 @@
     "displayName": "Sankey",
     "guid": "SankeyDiagram1446463184954",
     "visualClassName": "SankeyDiagram",
-    "version": "1.2.5",
+    "version": "1.2.7",
     "description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow.  Use it to find major contributions to an overall flow.",
     "supportUrl": "http://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-sankey"
   },
-  "apiVersion": "1.7.0",
+  "apiVersion": "1.6.0",
   "author": {
     "name": "Microsoft",
     "email": "[email protected]"

src/visual.ts

@@ -363,7 +363,7 @@ module powerbi.extensibility.visual {
             let createdNodes: SankeyDiagramNode[] = [];
             for (let nodeName in cycles) {
                 let firstCyclesNode: SankeyDiagramNode = (cycles[nodeName].filter((node: SankeyDiagramNode): boolean => {
-                    if (node.label.name === nodeName) {
+                    if ((node.label.name || "").toString() === (nodeName || "").toString()) {
                         return true;
                     }
                     return false;
@@ -506,16 +506,16 @@ module powerbi.extensibility.visual {
 
             let labelsDictionary: Object = { };
             sourceCategories.forEach((item: any, index: number) => {
-                labelsDictionary[item] = sourceCategoriesLabels[index];
+                labelsDictionary[item] = sourceCategoriesLabels[index] || "";
             });
             destinationCategories.forEach((item: any, index: number) => {
-                labelsDictionary[item] = destinationCategoriesLabels[index];
+                labelsDictionary[item] = destinationCategoriesLabels[index] || "";
             });
 
             let categories: any[] = sourceCategories.concat(destinationCategories);
 
             categories.forEach((item: any, index: number) => {
-                let formattedValue: string = valueFormatterForCategories.format((<string>labelsDictionary[item]).replace(SankeyDiagram.DublicatedNamePostfix, "")),
+                let formattedValue: string = valueFormatterForCategories.format((<string>labelsDictionary[item].toString()).replace(SankeyDiagram.DublicatedNamePostfix, "")),
                     label: SankeyDiagramLabel,
                     selectableDataPoint: SelectableDataPoint,
                     textProperties: TextProperties = {
@@ -527,7 +527,7 @@ module powerbi.extensibility.visual {
                 label = {
                     internalName: item,
                     name: item,
-                    formattedName: valueFormatterForCategories.format((<string>labelsDictionary[item]).replace(SankeyDiagram.DublicatedNamePostfix, "")),
+                    formattedName: valueFormatterForCategories.format((<string>labelsDictionary[item].toString()).replace(SankeyDiagram.DublicatedNamePostfix, "")),
                     width: textMeasurementService.measureSvgTextWidth(textProperties),
                     height: textMeasurementService.estimateSvgTextHeight(textProperties),
                     color: settings.labels.fill

test/_references.ts

@@ -32,7 +32,7 @@
 /// <reference path="../node_modules/@types/lodash/index.d.ts" />
 
 // Power BI API
-/// <reference path="../.api/v1.7.0/PowerBI-visuals.d.ts" />
+/// <reference path="../.api/v1.6.0/PowerBI-visuals.d.ts" />
 
 // Power BI Extensibility
 /// <reference path="../node_modules/powerbi-visuals-utils-dataviewutils/lib/index.d.ts" />

tsconfig.json

@@ -13,7 +13,7 @@
     "node_modules/@types/d3/index.d.ts",
     "node_modules/@types/jquery/index.d.ts",
     "node_modules/@types/lodash/index.d.ts",
-    ".api/v1.7.0/PowerBI-visuals.d.ts",
+    ".api/v1.6.0/PowerBI-visuals.d.ts",
     "node_modules/powerbi-visuals-utils-dataviewutils/lib/index.d.ts",
     "node_modules/powerbi-visuals-utils-typeutils/lib/index.d.ts",
     "node_modules/powerbi-visuals-utils-svgutils/lib/index.d.ts",