fix(types): fix waitForSelector typing to not union null when appropriate #6344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with the
types.d.ts
file regardingwaitForSelector
when passing some options, but no state. When nostate
key is provided, the return type would include null. This is despite the default state value isvisible
and shouldn't allownull
.I discovered when doing something like below. The example shows passing no options gives the correct return type, but not when options are passed.

Source Code
I found the solution, added some tests, but I also fixed the
canBeNull
assertion because my new test case wouldn't fail the tests as they were (even though the types clearly included null, but the assertion was missing it.) Looking at some code review comments this might have been the case for a while. If anyone has some insight, I'd love to hear it.