fix(launchdoctor): make launch doctor to warn on Win7 #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows 7 was end-of-lifed on January 14, 2020. We don't support this system, but we'd like to have a best-effort to work there. It does look like Chromium is missing some libraries on Win 7, however it still manages to work there. To support this usecase, this patch starts printing console warning about missing libraries on Win 7 only instead of refusing to launch. Fixes microsoft#3496
yury-s
approved these changes
Dec 15, 2020
dgozman
approved these changes
Dec 15, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Dec 15, 2020
aslushnikov
added a commit
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 7 was end-of-lifed on January 14, 2020. We don't support this
system, but we'd like to have a best-effort to work there.
It does look like Chromium is missing some libraries on Win 7, however
it still manages to work there. To support this usecase, this patch
starts printing console warning about missing libraries on Win 7 only
instead of refusing to launch.
Fixes #3496