chore: expose adb devices and actions #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
android
branch
6 times, most recently
from
f6aff88 to
7fe1027
Compare
dgozman
approved these changes
Dec 9, 2020
| version: '0.0.2', // Manually manage playwright-android version. | ||
| description: 'A high-level API to automate Chrome for Android', | ||
| browsers: [], | ||
| files: [...PLAYWRIGHT_CORE_FILES, ...FFMPEG_FILES, 'android-types.d.ts', 'bin/android-driver.apk', 'bin/android-driver-target.apk'], |
There was a problem hiding this comment.
Please take a look at npmignore file. I think we are either shipping apks to all packages, or ignoring them in playwright-android.
| try { | ||
| socket = await this._backend.open(`localabstract:playwright_android_driver_socket`); | ||
| } catch (e) { | ||
| await new Promise(f => setTimeout(f, 100)); |
There was a problem hiding this comment.
I guess we'll need a timeout for this operation.
| } | ||
| } | ||
|
|
||
| class AndroidBrowser extends EventEmitter { |
There was a problem hiding this comment.
Shall we mark this as implements Transport? IIUC, this serves as a transport for protocol connection?
| const controller = new ProgressController(); | ||
| await controller.run(async progress => { | ||
| await browser._defaultContext!._loadDefaultContext(progress); | ||
| }); |
There was a problem hiding this comment.
For proper timeout managing, you have to wrap everything in this method into controller.run and pass TimeoutSettings.timeout(options) to it.
There was a problem hiding this comment.
Doing it in a follow up...
| @@ -111,10 +113,11 @@ DEPS['src/server/common/'] = []; | |||
| DEPS['src/server/injected/'] = ['src/server/common/']; | |||
|
|
|||
| // Electron and Clank use chromium internally. | |||
| DEPS['src/server/android/'] = [...DEPS['src/server/'], 'src/server/chromium/', 'src/protocol/transport.ts']; | |||
| DEPS['src/server/electron/'] = [...DEPS['src/server/'], 'src/server/chromium/']; | |||
| DEPS['src/server/clank/'] = [...DEPS['src/server/'], 'src/server/chromium/']; | |||
There was a problem hiding this comment.
Nothing works w/o it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1122