browser(webkit): drag support for wpe and gtk #4639
Conversation
| +++ b/Source/WebCore/page/wpe/DragControllerWPE.cpp | ||
| @@ -0,0 +1,79 @@ | ||
| +/* | ||
| + * Copyright (C) 2007-20 Apple Inc. All rights reserved. |
There was a problem hiding this comment.
It might be easier to rename DragControllerGtk.cpp to DragControllerGlib.cpp and use it in both linux builds. This was they wouldn't diverge at least. But up to you.
There was a problem hiding this comment.
I wasn't able to get it to easily compile without a much larger diff. I am not super worried about this code diverging, because we would probably rather match the mac behavior than whatever gtk decides to do. I'll try a follow up patch to see how it looks though.
|
|
||
| #if PLATFORM(GTK) | ||
| explicit Pasteboard(const String& name); | ||
| - explicit Pasteboard(SelectionData&); |
| String Pasteboard::readString(const String& type) | ||
| { | ||
| + if (m_selectionData) | ||
| + return m_selectionData->text(); |
There was a problem hiding this comment.
Do we care about other selection data types?
|
|
||
| - dragData = DragData(pasteboardName, clientPosition, globalPosition, draggingSourceOperationMask, applicationFlags, dragDestinationActionMask); | ||
| + dragData = DragData(firstArg, clientPosition, globalPosition, draggingSourceOperationMask, applicationFlags, dragDestinationActionMask); | ||
| +#if PLATFORM(COCOA) |
There was a problem hiding this comment.
Windows doesn't have drag & drop support in webkit2, so it never gets used. My follow up patch adds windows support.
| - String pasteboardName; | ||
| - Vector<String> fileNames; | ||
| +#if PLATFORM(WPE) | ||
| + SelectionData* selectionData = new SelectionData(); |
There was a problem hiding this comment.
Where is it deleted? Consider converting it into a smart pointer.
There was a problem hiding this comment.
I couldn't get a smart pointer working, but I refactored this so wpe works the same as gtk and doesn't need this code.
| + // We intercept any drags generated by this mouse event | ||
| + // to prevent them from creating actual drags in the host | ||
| + // operating system. | ||
| + // So far this is only implemented for WPE. |
There was a problem hiding this comment.
does GTK code not work (I see it is enabled)?
There was a problem hiding this comment.
stale comment, fixed!
JoelEinbinder
force-pushed
the
wk_drag
branch
from
6e4e3fc to
2f9036b
Compare
mac support coming next, followed by windows.
JoelEinbinder/webkit@036ee12