New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): do not hang on close when there is a dialog #4332

Merged

aslushnikov merged 2 commits into microsoft:master from yury-s:wk-close-with-dialog

Nov 4, 2020

Member

yury-s commented Nov 4, 2020

No description provided.


          browser(webkit): do not hang on close when there is a dialog

b0d06af

aslushnikov reviewed

View reviewed changes

browser_patches/prepare_checkout.sh Outdated

@@ @@ -124,11 +124,11 @@ git apply --index --whitespace=nowarn $PATCHES_PATH/* @@
               if [[ ! -z "${WEBKIT_EXTRA_FOLDER_PATH}" ]]; then
                 echo "-- adding WebKit embedders"
-                cp -r "${WEBKIT_EXTRA_FOLDER_PATH}" ./Tools/Playwright
+                cp -r "${WEBKIT_EXTRA_FOLDER_PATH}/" ./Tools/Playwright

Collaborator

aslushnikov Nov 4, 2020

Let's not land this ATM - trailing slash in the "SRC" is an anti-pattern. I'd like to understand first why would it be needed.


          revert trailing SRC slashes as per offline discussion

56bdde2

aslushnikov approved these changes

View reviewed changes

aslushnikov merged commit 890add9 into microsoft:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet