Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(screencast): respect i/o backpressure when writing into ffmpeg #4164

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Oct 16, 2020

Fixes #4148


const close = this._gracefullyClose;
this._gracefullyClose = null;
this.writeFrame(Buffer.from([]), this._lastFrameTimestamp + (monotonicTime() - this._lastWriteTimestamp) / 1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrap in if (this._lastWriteTimestamp) { for the case when there are now frames.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are waiting for a frame now unconditionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] browserContext.close takes too long when recording videos
2 participants