Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api.json): do not copy documentation from base class members #4048

Merged
merged 1 commit into from
Oct 3, 2020
Merged

fix(api.json): do not copy documentation from base class members #4048

merged 1 commit into from
Oct 3, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Oct 2, 2020

  • Add extends field
  • Do not copy fields from super class to subclass definition

@pavelfeldman
Copy link
Member

Are you trying to save on the footprint? (We'll need to update Python generators)

@yury-s
Copy link
Member Author

yury-s commented Oct 3, 2020

No, this polutes generated java interfaces with extra methods instead of adding only the new ones.

@yury-s yury-s merged commit fbe0fb2 into microsoft:master Oct 3, 2020
@yury-s yury-s deleted the api-json-no-copy-base-docs branch October 3, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @pavelfeldman