Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: locator.visible #34905

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: locator.visible #34905

merged 1 commit into from
Feb 25, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Feb 24, 2025

No description provided.

@dgozman dgozman marked this pull request as ready for review February 24, 2025 20:22
@dgozman dgozman force-pushed the feat-locator-visible branch from f8ae8ff to 0d5ffca Compare February 24, 2025 21:24

This comment has been minimized.

This comment has been minimized.

@dgozman dgozman force-pushed the feat-locator-visible branch from 0d5ffca to 6ab8585 Compare February 25, 2025 09:51
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node22
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @macos-latest-node18-1
⚠️ [chromium-page] › tests/page/page-history.spec.ts:94:3 › goBack/goForward should work with bfcache-able pages @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:124:5 › mobile viewport › respect meta viewport tag @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-filechooser.spec.ts:24:5 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38683 passed, 793 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants