Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria snapshot): make rebase work when options are specified #34409

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 21, 2025

No description provided.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [installation tests] › tests/playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://cdn.playwright.dev) @package-installations-windows-latest
❌ [installation tests] › tests/playwright-cli-install-should-work.spec.ts:24:5 › install command should work @package-installations-windows-latest

10 flaky ⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @macos-latest-node18-1
⚠️ [installation tests] › tests/playwright-cli-install-should-work.spec.ts:53:5 › should be able to remove browsers @package-installations-windows-latest
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node20-1
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:228:3 › should use socks proxy @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37596 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit cf90c0f into microsoft:main Jan 22, 2025
28 of 29 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Jan 22, 2025
dgozman added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants