Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: step timeout improvements #34386

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jan 18, 2025

  • display errors for interrupted actions within step
  • docs: clarify what happens when step times out
  • align timeout message with test timeout
image

Reference #33475

This comment has been minimized.

@yury-s yury-s merged commit 372d419 into microsoft:main Jan 18, 2025
29 checks passed
@yury-s yury-s deleted the test-step-timeout-fixes branch January 18, 2025 05:15
yury-s added a commit to yury-s/playwright that referenced this pull request Jan 18, 2025
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › tests/library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:210:5 › selector generator › should use internal:has-text with regexp @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:95:1 › should open two trace viewers @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1719:1 › should toggle canvas rendering @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37589 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants