-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bidi): disable thottling of background tabs in Firefox #34381
Conversation
Test results for "tests 1"9 flaky37588 passed, 648 skipped Merge workflow run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It looks like we don't use this preferences with juggler (see https://github.com/microsoft/playwright/tree/main/browser_patches/firefox/preferences), which means there is probably another preference that helps us avoid the throttling. I'll try to incorporate this settings to our other builds too and see if it makes a difference.
Update: I just noticed from your description that at lease 'layout.testing.top-level-always-active' was added a few days ago, no wonder we don't have it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's another reason to have a canonical set of preferences that should be used for testing in Firefox.
Yes, you probably want to add this preference there as well.
Correct. After investigation of the raf test case in your repository I noticed that this was a problem and requested a possibility to turn throttling of for rendering. Is there a way to see how this affects the non BiDi-tests for Firefox? Do you have some general performance numbers recorded to detect perf changes?
The preferences as used in this PR are not going to become default preferences when Marionette or WebDriver BiDi is active in Firefox. Our aim is to run as close as possible to the users settings, and running tests in parallel is usually not such a thing, but could be requested by the user. Maybe it could be some kind of configuration option. |
With this patch throttling of background tabs will no longer happen. This PR changes the following:
@yury-s at least one test is no longer timing out with Firefox. I'm not sure if others might benefit from that as well. Also depending on your usage of
setTimeout
in general you should see a big improvement.