Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): Handle headers properly in BiDi network.continueRequest #34268

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

juliandescottes
Copy link
Contributor

@juliandescottes juliandescottes commented Jan 9, 2025

Headers should be converted to valid bidi request headers.

Should fix the following tests with bidi:
page/page-request-continue.spec.ts :: continue should delete headers on redirects
page/page-request-continue.spec.ts :: continue should propagate headers to redirects
page/page-request-continue.spec.ts :: propagate headers cross origin redirect after interception

This comment has been minimized.

@juliandescottes juliandescottes force-pushed the bidi-continueRequest-headers branch from 3f48f4e to 06361bf Compare January 9, 2025 20:57
@juliandescottes juliandescottes force-pushed the bidi-continueRequest-headers branch from 06361bf to b6da487 Compare January 9, 2025 20:58
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test results for "tests 1"

7 flaky ⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @macos-latest-node18-1
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-20.04-chromium-tip-of-tree
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node20-1
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-launch.spec.ts:72:3 › should reject if executable path is invalid @webkit-ubuntu-22.04-node18

37545 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt requested a review from yury-s January 10, 2025 09:46
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@yury-s yury-s merged commit ca94291 into microsoft:main Jan 10, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants