fix(defineConfig): fix type issue passing custom property in the seco… #33774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd config param in defineConfig function
To fix TS error: Object literal may only specify known properties, and customOption does not exist in type
When playwright.config.ts as follow:
```
type Options = {
customOption: any[]
}
export default defineConfig<Options>(BasePlaywrightConfig, {
use: {
customOption,
},
})
```
Signed-off-by: yangsisi <[email protected]>
Test results for "tests 1"1 flaky37173 passed, 650 skipped Merge workflow run. |
dgozman
reviewed
Nov 27, 2024
There was a problem hiding this comment.
@yangsisi0422 This is a great find! However, the changes should be made in a different place:
- here: https://github.com/microsoft/playwright/blob/main/packages/playwright-ct-core/index.d.ts#L51-L56
- and here: https://github.com/microsoft/playwright/blob/main/utils/generate_types/overrides-test.d.ts#L484-L489
While you are fixing this, could you please also update the defineConfig<T, W> override in the same way? Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd config param in defineConfig function
To fix TS error: Object literal may only specify known properties, and customOption does not exist in type
When playwright.config.ts as follow: