chore(ui): test that UI works behind proxy #33767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Nov 26, 2024
| @@ -16,6 +16,9 @@ | |||
|
|
|||
| import { createImage } from './playwright-test-fixtures'; | |||
| import { test, expect, retries } from './ui-mode-fixtures'; | |||
| import http from 'node:http'; | |||
| import httpProxy from 'http-proxy'; | |||
| import { ManualPromise } from 'packages/playwright-core/lib/utils/manualPromise'; | |||
There was a problem hiding this comment.
We usually use relative imports I think, packages/playwright works by accident here I think.
There was a problem hiding this comment.
this was a remnant, didn't even use it 😅
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 37178 passed, 650 skipped Merge workflow run. |
|
We discussed offline that we'd prefer not to have two proxy libraries within the project. But since This PR is superceded by #33771, which instead extends |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to ensure we support running UI behind a proxy. It adds the
http-proxylibrary to test this. As discussed, we need that for websocket support. I'll try replacing the existingproxylibrary with that in a separate PR.Closes #33705.