Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test runner): page.pause() should enable debug mode #32714

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(test runner): page.pause() should enable debug mode #32714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/playwright/src/worker/timeoutManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ export class TimeoutManager {

setIgnoreTimeouts() {
this._ignoreTimeouts = true;
if (this._running)
this._updateTimeout(this._running);
}

interrupt() {
Expand Down
22 changes: 22 additions & 0 deletions tests/playwright-test/playwright.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,3 +872,25 @@ test('should allow dynamic import in evaluate', async ({ runInlineTest, server }
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
});

test('page.pause() should disable test timeout', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.ts': `
import { test, expect } from '@playwright/test';

test('test', async ({ page }) => {
test.setTimeout(2000);
dgozman marked this conversation as resolved.
Show resolved Hide resolved

await Promise.race([
page.pause(),
new Promise(f => setTimeout(f, 3000)),
]);

console.log('success!');
});
`,
}, { headed: true });
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
expect(result.output).toContain('success!');
});