chore: remove bright counter from sidebar tab selector #31975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Aug 1, 2024
pavelfeldman
reviewed
Aug 1, 2024
| suffix = ` 🔵✖️${tab.count}`; | ||
| if (tab.errorCount === 1) | ||
| suffix = ` 🔴`; | ||
| else if (tab.errorCount) |
There was a problem hiding this comment.
We seem to have this code in a regular tabbed pane mode.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Aug 1, 2024
Test results for "tests 1"1 failed 5 flaky29522 passed, 702 skipped Merge workflow run. |
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
Aug 1, 2024
…ar tab selector Removing the following icon:  HTML `options` element cannot be styled, so just removing the counter in sidebar mode: <img width="348" alt="image" src="https://github.com/user-attachments/assets/d636dca2-5007-41f7-866e-3a0f604d46fc">
yury-s
added a commit
that referenced
this pull request
Aug 2, 2024
#31976) …lector Removing the following icon:  HTML `options` element cannot be styled, so just removing the counter in sidebar mode: <img width="348" alt="image" src="https://github.com/user-attachments/assets/d636dca2-5007-41f7-866e-3a0f604d46fc">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the following icon:
HTML
optionselement cannot be styled, so just removing the counter in sidebar mode: