-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with audio in macOS 14 on GitHub Actions #30410
Conversation
This comment has been minimized.
This comment has been minimized.
Impressive investigation! I tried my luck before in debugging this but was not able to. Was there a trick you had to see the GUI of the macOS runner? |
Test results for "tests 2"1 fatal errors, not part of any test 64 flaky2 interrupted182756 passed, 8031 skipped, 1288 did not run Merge workflow run. |
Signed-off-by: Max Schmitt <[email protected]>
Test results for "tests 1"3 flaky27365 passed, 671 skipped Merge workflow run. |
@mxschmitt I found it in the linked issue actions/runner-images#9330. Looks like you can use
|
While investigating a similar issue in my own repository, I noticed that some tests that play audio are failing on
macos-14
(e.g. https://github.com/microsoft/playwright/actions/runs/8727564874/job/23945367541). This happens because a microphone permission dialog appears whenever sound is first played.This PR adds the microphone permission for all apps to the TCC database, preventing the issue from happening.
More info: actions/runner-images#9330
In particular it fixes the following tests which were failing on Firefox and Chromium on newer macOS versions.