Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add content for debugging tools #2865

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

arjunattam
Copy link
Contributor

No description provided.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

1. Set a breakpoint in VS Code
* Use the `debugger` keyword or set a breakpoint in the VS Code UI

1. Run your Node.js script from the terminal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a special debugging terminal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I can tell, vscode 1.46+ does not require a special terminal

docs/debug.md Outdated
### Debugging Selectors

PWDEBUG configures a `playwright` object in the browser, which can be used to
inspect with [Playwright selectors](selectors.md), including the text selector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect with Playwright selectors looks awkward to me 😄

docs/debug.md Outdated
inspect with [Playwright selectors](selectors.md), including the text selector
or composite selectors. To use this:

1. Open developer tools console during execution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...., for example when paused on a breakpoint in the Playwright script.

docs/debug.md Outdated Show resolved Hide resolved
@arjunattam arjunattam merged commit 6a1bd3a into microsoft:master Jul 8, 2020
aslushnikov pushed a commit that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants