Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick(#28198): feat(recorder): UX updates for assertion tools #28202

Merged
merged 1 commit into from
Nov 16, 2023
Merged

cherry-pick(#28198): feat(recorder): UX updates for assertion tools #28202

merged 1 commit into from
Nov 16, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Nov 16, 2023

  • No locator editor.
  • No value editor for toHaveValue.
  • Visual feedback for toBeVisible/toHaveValue.
  • UI tweaks.

@dgozman
cherry-pick(microsoft#28198): feat(recorder): UX updates for assertio…
2ed0dbb 
…n tools

- No locator editor.
- No value editor for `toHaveValue`.
- Visual feedback for `toBeVisible`/`toHaveValue`.
- UI tweaks.
@dgozman dgozman merged commit b894916 into microsoft:release-1.40 Nov 16, 2023
28 of 29 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT

3 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL

26146 passed, 612 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dgozman