Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ignoreSnapshots): print a notice when ignoreSnapshots option is on #17317

Merged
merged 3 commits into from
Sep 14, 2022
Merged

fix(ignoreSnapshots): print a notice when ignoreSnapshots option is on #17317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73d653d
fix(ignoreSnapshots): print a notice when ignoreSnapshots option is on
aslushnikov Sep 14, 2022
828a0a2
address comments
aslushnikov Sep 14, 2022
26759a8
fix colors
aslushnikov Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/playwright-test/src/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { Loader } from './loader';
import type { FullResult, Reporter, TestError } from '../types/testReporter';
import { Multiplexer } from './reporters/multiplexer';
import { formatError } from './reporters/base';
import { colors } from 'playwright-core/lib/utilsBundle';
import DotReporter from './reporters/dot';
import GitHubReporter from './reporters/github';
import LineReporter from './reporters/line';
Expand Down Expand Up @@ -401,6 +402,15 @@ export class Runner {
if (result.status !== 'passed')
return result;

if (config._ignoreSnapshots) {
this._reporter.onStdOut?.(colors.dim([
'NOTE: running with "ignoreSnapshots" option. All of the following asserts are silently ignored:',
'- expect().toMatchSnapshot()',
'- expect().toHaveScreenshot()',
'',
].join('\n')));
}

// 14. Run tests.
try {
const sigintWatcher = new SigIntWatcher();
Expand Down