docs(intro-section): fix links #17241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfgreffier
reviewed
Sep 11, 2022
docs/src/test-reporters-js.md
Outdated
| }; | ||
|
|
||
| module.exports = config; | ||
| ``` | ||
|
|
||
| ```js tab=js-ts | ||
| // playwright.config.ts | ||
| import type { PlaywrightTestConfig } from '@playwright/test'; | ||
| import type { PlaywrightTestConfig } from "@playwright/test"; |
There was a problem hiding this comment.
There is a lot of formatting in this PR, but I think most of it does not fit Playwright coding conventions. The codebase and most of the examples are using single quotes, for example.
There was a problem hiding this comment.
Thanks for catching it. My formatter had different settings. Fixed the docs.
docs/src/test-reporters-js.md
Outdated
| test("embed attachments, including its content, on the JUnit report", async ({}, testInfo) => { | ||
| const file = testInfo.outputPath("evidence1.txt"); | ||
| require("fs").writeFileSync(file, "hello", "utf8"); | ||
| await testInfo.attach("evidence1.txt", { |
There was a problem hiding this comment.
Maybe the more compact code style that was originally used is better for docs ? 🤔
await testInfo.attach('evidence1.txt', { path: file, contentType: 'text/plain' });
debs-obrien
approved these changes
Sep 12, 2022
|
Great work guys. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the link to getting started sections.
cc - @debs-obrien