feat: expect(locator).toHaveAttribute to assert attribute presence #16767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes `expect(locator).toHaveAttribute()` so that the `value` argument can be omitted. When done so, the method will assert attribute existance. Fixes microsoft#16517
dgozman
approved these changes
Aug 23, 2022
rwoll
added a commit
to rwoll/playwright
that referenced
this pull request
Sep 16, 2022
Revert "docs(python): add missing NotToHaveAttribute overloads (microsoft#17371)" This reverts commit 2e1ea29. Revert "docs(release-notes): add 1.26 release notes for language ports (microsoft#17345)" This reverts commit 4b8a85e. Revert "test: unflake "should support boolean attribute with options" (microsoft#17024)" This reverts commit 1dc05bd. Revert "fix: support toHaveAttribute(name, options) (microsoft#16941)" This reverts commit f30ac1d. Revert "feat: expect(locator).toHaveAttribute to assert attribute presence (microsoft#16767)" This reverts commit 622c73c.
rwoll
added a commit
that referenced
this pull request
Sep 16, 2022
Relates #16517. Revert "docs(python): add missing NotToHaveAttribute overloads (#17371)" This reverts commit 2e1ea29. Revert "docs(release-notes): add 1.26 release notes for language ports (#17345)" This reverts commit 4b8a85e. Revert "test: unflake "should support boolean attribute with options" (#17024)" This reverts commit 1dc05bd. Revert "fix: support toHaveAttribute(name, options) (#16941)" This reverts commit f30ac1d. Revert "feat: expect(locator).toHaveAttribute to assert attribute presence (#16767)" This reverts commit 622c73c.
This was referenced Oct 18, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 25, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
expect(locator).toHaveAttribute()so that thevalueargument can be omitted. When done so, the method willassert attribute existance.
Fixes #16517