-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pwt): compatibility in CWD with wrong casing #16636
fix(pwt): compatibility in CWD with wrong casing #16636
Conversation
51fbb9f
to
bb062f7
Compare
bb062f7
to
ee6d28f
Compare
@@ -27,7 +27,7 @@ const config: PlaywrightTestConfig = { | |||
timeout: 5 * 60 * 1000, | |||
retries: 0, | |||
reporter: process.env.CI ? [ | |||
['dot'], | |||
['list'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only have a small number of long running tests, so list is better there.
ee6d28f
to
77884e2
Compare
1fe567f
to
c080a45
Compare
I'm still fuzzy on what it going on here. |
Abstract problem:
this ends up that the state inside is different, since these are different instances.
e.g. to it, so 1): setCurrentlyLoadingFileSuite
2): currentlyLoadingFileSuite
|
…ith wrong casing (microsoft#16636)"
Fixes #16347
Fixes #9193
This bug only affects PowerShell 5.X and 6.X experience, when using PowerShell 7.X its not possible anymore to enter a directory with incorrect casing. PowerShell/PowerShell#9250 was fixing it upstream - this patch workarounds it and normalizes paths before requiring them.