-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Firefox and WebKit request.resourceType() incorrect with EventSource connection #2189
Comments
rdmurphy
changed the title
[BUG] Firefox and WebKit resourceType incorrect with EventSource connection
[BUG] Firefox and WebKit request.resourceType() incorrect with EventSource connection
May 11, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
May 28, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
May 28, 2020
aslushnikov
added a commit
that referenced
this issue
May 28, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
May 28, 2020
Internal request cause helps clarify certain types of requests, e.g. event source. Review URL: aslushnikov/juggler@296ecad References microsoft#2189
This was referenced May 28, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
May 28, 2020
The resource type for `eventsource` events in webkit seems to be hard to reach from our instrumentation points. This suggests an alternative approach for webkit to treat all requests with 'accept' header of server-sent events as server-sent events. References microsoft#2189
aslushnikov
added a commit
that referenced
this issue
May 28, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
May 29, 2020
Review URL: aslushnikov/WebKit@721d999 References microsoft#2189
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
May 31, 2020
Review URL: aslushnikov/WebKit@77a2901 This uses `initiatorIdentifier` to mark resource request as originating from event source. This is alternative to microsoft#2396. References microsoft#2189
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
Jun 1, 2020
Review URL: aslushnikov/WebKit@77a2901 This uses `initiatorIdentifier` to mark resource request as originating from event source. This is alternative to microsoft#2396. References microsoft#2189
aslushnikov
added a commit
that referenced
this issue
Jun 1, 2020
Review URL: aslushnikov/WebKit@77a2901 This uses `initiatorIdentifier` to mark resource request as originating from event source. This is alternative to #2396. References #2189
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
Jun 1, 2020
This rolls webkit to r1250 where we report event source. Fixes microsoft#2189
aslushnikov
added a commit
that referenced
this issue
Jun 1, 2020
This rolls webkit to r1250 where we report event source. Fixes #2189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context:
Code Snippet
Help us help you! Put down a short code snippet that illustrates your bug and
that we can run and debug locally. For example:
Describe the bug
Hello! 👋
I've been experimenting with Playwright and using it to test interactions with an
EventSource
, and as part of that process I was trying to use this library to ensure that theEventSource
successfully connects in each browser. However, each browser reports out therequest.resourceType()
of anEventSource
connection differently.Chromium reports it out correctly, and returns
eventsource
. Firefox confusingly returnsxhr
. And Webkit has no idea and reports outunknown
.I assume this may be a byproduct of how each browser reports out network connections and is out of the control of Playwright, but just in case it's an actual bug I wanted to drop it here. If it is by design, is there any other way to confidently detect
EventSource
connections in those browsers?Thank you!
The text was updated successfully, but these errors were encountered: