fix(protocol): annotate file buffer as binary (#4272)

microsoft · Oct 28, 2020 · ece84ec · ece84ec
1 parent 05278b8
commit ece84ec
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/protocol/channels.ts b/src/protocol/channels.ts
@@ -1490,7 +1490,7 @@ export type FrameSetInputFilesParams = {
   files: {
     name: string,
     mimeType: string,
-    buffer: string,
+    buffer: Binary,
   }[],
   timeout?: number,
   noWaitAfter?: boolean,
@@ -1982,7 +1982,7 @@ export type ElementHandleSetInputFilesParams = {
   files: {
     name: string,
     mimeType: string,
-    buffer: string,
+    buffer: Binary,
   }[],
   timeout?: number,
   noWaitAfter?: boolean,

diff --git a/src/protocol/protocol.yml b/src/protocol/protocol.yml
@@ -1243,7 +1243,7 @@ Frame:
             properties:
               name: string
               mimeType: string
-              buffer: string
+              buffer: binary
         timeout: number?
         noWaitAfter: boolean?
 
@@ -1660,7 +1660,7 @@ ElementHandle:
             properties:
               name: string
               mimeType: string
-              buffer: string
+              buffer: binary
         timeout: number?
         noWaitAfter: boolean?
 

diff --git a/src/protocol/validator.ts b/src/protocol/validator.ts
@@ -592,7 +592,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
     files: tArray(tObject({
       name: tString,
       mimeType: tString,
-      buffer: tString,
+      buffer: tBinary,
     })),
     timeout: tOptional(tNumber),
     noWaitAfter: tOptional(tBoolean),
@@ -781,7 +781,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
     files: tArray(tObject({
       name: tString,
       mimeType: tString,
-      buffer: tString,
+      buffer: tBinary,
     })),
     timeout: tOptional(tNumber),
     noWaitAfter: tOptional(tBoolean),