revert: testrunner: make environment a simple class (#2769) (#2790)

microsoft · Jul 1, 2020 · e467ea5 · e467ea5
1 parent bd8e0a7
commit e467ea5
Show file tree

Hide file tree

Showing 9 changed files with 397 additions and 373 deletions.
diff --git a/test/browsercontext.spec.js b/test/browsercontext.spec.js
@@ -16,7 +16,7 @@
  */
 
 const utils = require('./utils');
-const {FFOX, CHROMIUM, WEBKIT, MAC} = utils.testOptions(browserType);
+const {FFOX, CHROMIUM, WEBKIT, MAC, CHANNEL} = utils.testOptions(browserType);
 
 describe('BrowserContext', function() {
   it('should create new context', async function({browser}) {
@@ -121,7 +121,7 @@ describe('BrowserContext', function() {
     let error = await promise;
     expect(error.message).toContain('Context closed');
   });
-  it('close() should be callable twice', async({browser}) => {
+  it.fail(CHANNEL)('close() should be callable twice', async({browser}) => {
     const context = await browser.newContext();
     await Promise.all([
       context.close(),

diff --git a/test/environments.js b/test/environments.js
diff --git a/test/page.spec.js b/test/page.spec.js
@@ -18,7 +18,7 @@
 const path = require('path');
 const util = require('util');
 const vm = require('vm');
-const {FFOX, CHROMIUM, WEBKIT, WIN} = require('./utils').testOptions(browserType);
+const {FFOX, CHROMIUM, WEBKIT, WIN, CHANNEL} = require('./utils').testOptions(browserType);
 
 describe('Page.close', function() {
   it('should reject all promises when page is closed', async({context}) => {
@@ -154,7 +154,7 @@ describe.fail(FFOX && WIN)('Page.Events.Crash', function() {
     const error = await promise;
     expect(error.message).toContain('Navigation failed because page crashed');
   });
-  it('should be able to close context when page crashes', async({page}) => {
+  it.fail(CHANNEL)('should be able to close context when page crashes', async({page}) => {
     await page.setContent(`<div>This page should crash</div>`);
     crash(page);
     await page.waitForEvent('crash');
@@ -1306,3 +1306,8 @@ describe('Page api coverage', function() {
   });
 });
 
+describe.skip(!CHANNEL)('Page channel', function() {
+  it('page should be client stub', async({page, server}) => {
+    expect(!!page._channel).toBeTruthy();
+  });
+});