Skip to content

Commit

Permalink
fix(html-reporter): duplicate attachment name (#16929)
Browse files Browse the repository at this point in the history
Fixes #16456.

The extra span/name was coming from
https://github.com/microsoft/playwright/blob/077b8a928960493a4cf275bc4fc4d4176b2a6098/packages/html-reporter/src/links.tsx#L72
(in conjunction with the line above it).

These two lines assume `path` and `body` are mutally exclusive.

Regression likely introduced by the PR that added the now removed line #10778.
  • Loading branch information
rwoll authored Sep 3, 2022
1 parent 4dc919f commit c58bfd0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/playwright-test/src/reporters/html.ts
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,6 @@ class HtmlBuilder {
name: a.name,
contentType: a.contentType,
path: 'data/' + sha1,
body: a.body,
};
}

Expand Down

0 comments on commit c58bfd0

Please sign in to comment.