add comment about connect

microsoft · Sep 16, 2024 · 9479423 · 9479423
1 parent c0c036b
commit 9479423
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/playwright-core/src/server/fetch.ts b/packages/playwright-core/src/server/fetch.ts
@@ -320,12 +320,13 @@ export abstract class APIRequestContext extends SdkObject {
 
       const request = requestConstructor(url, requestOptions as any, async response => {
         const notifyRequestFinished = (body?: Buffer) => {
+          // spec: http://www.softwareishard.com/blog/har-12-spec/#timings
           const timings: har.Timings = {
             send: requestFinishAt! - startAt,
             wait: firstByteAt! - requestFinishAt!,
             receive: endAt! - firstByteAt!,
             dns: dnsLookupAt ? dnsLookupAt - startAt : -1,
-            connect: (tlsHandshakeAt ?? tcpConnectionAt!) - startAt,
+            connect: (tlsHandshakeAt ?? tcpConnectionAt!) - startAt, // "If [ssl] is defined then the time is also included in the connect field "
             ssl: tlsHandshakeAt ? tlsHandshakeAt - tcpConnectionAt! : -1,
             blocked: -1,
           };