Rename option to viewportSize

microsoft · Feb 9, 2021 · 77cf73d · 77cf73d
1 parent 966f335
commit 77cf73d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/docs/src/api/class-page.md b/docs/src/api/class-page.md
@@ -2051,8 +2051,8 @@ page.set_viewport_size({"width": 640, "height": 480})
 page.goto("https://example.com")
 ```
 
-### param: Page.setViewportSize.viewport
-- `viewport` <[Object]>
+### param: Page.setViewportSize.viewportSize
+- `viewportSize` <[Object]>
   - `width` <[int]> page width in pixels.
   - `height` <[int]> page height in pixels.
 

diff --git a/docs/src/api/params.md b/docs/src/api/params.md
@@ -195,13 +195,21 @@ Whether to ignore HTTPS errors during navigation. Defaults to `false`.
 Toggles bypassing page's Content-Security-Policy.
 
 ## context-option-viewport
-* langs: java, js
+* langs: js
 - `viewport` <[null]|[Object]>
   - `width` <[int]> page width in pixels.
   - `height` <[int]> page height in pixels.
 
 Sets a consistent viewport for each page. Defaults to an 1280x720 viewport. `null` disables the default viewport.
 
+## csharp-java-context-option-viewport
+* langs: csharp, java
+- `viewportSize` <[null]|[Object]>
+  - `width` <[int]> page width in pixels.
+  - `height` <[int]> page height in pixels.
+
+Sets a consistent viewport for each page. Defaults to an 1280x720 viewport. `null` disables the default viewport.
+
 ## evaluate-expression
 - `expression` <[string]>
 
@@ -496,6 +504,7 @@ The default value can be changed by using the [`method: BrowserContext.setDefaul
 - %%-context-option-bypasscsp-%%
 - %%-context-option-viewport-%%
 - %%-python-context-option-viewport-%%
+- %%-csharp-java-context-option-viewport-%%
 - %%-python-context-option-no-viewport-%%
 - %%-context-option-useragent-%%
 - %%-context-option-devicescalefactor-%%

diff --git a/types/types.d.ts b/types/types.d.ts
@@ -2638,9 +2638,9 @@ export interface Page {
    * await page.goto('https://example.com');
    * ```
    * 
-   * @param viewport 
+   * @param viewportSize 
    */
-  setViewportSize(viewport: {
+  setViewportSize(viewportSize: {
     /**
      * page width in pixels.
      */