fix(rpc): protocol Route.fulfill (#3200)

microsoft · Jul 30, 2020 · 52eb6c6 · 52eb6c6
1 parent 3bd9777
commit 52eb6c6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 13 deletions.
diff --git a/src/rpc/channels.ts b/src/rpc/channels.ts
@@ -2055,13 +2055,13 @@ export type RouteContinueOptions = {
 };
 export type RouteContinueResult = void;
 export type RouteFulfillParams = {
-  status: number,
-  headers: {
+  status?: number,
+  headers?: {
     name: string,
     value: string,
   }[],
-  body: string,
-  isBase64: boolean,
+  body?: string,
+  isBase64?: boolean,
 };
 export type RouteFulfillOptions = {
 

diff --git a/src/rpc/protocol.yml b/src/rpc/protocol.yml
@@ -1694,16 +1694,17 @@ Route:
 
     fulfill:
       parameters:
-        status: number
+        # default is 200
+        status: number?
         headers:
-          type: array
+          type: array?
           items:
             type: object
             properties:
               name: string
               value: string
-        body: string
-        isBase64: boolean
+        body: string?
+        isBase64: boolean?
 
 
 

diff --git a/src/rpc/validator.ts b/src/rpc/validator.ts
@@ -803,13 +803,13 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
     postData: tOptional(tBinary),
   });
   scheme.RouteFulfillParams = tObject({
-    status: tNumber,
-    headers: tArray(tObject({
+    status: tOptional(tNumber),
+    headers: tOptional(tArray(tObject({
       name: tString,
       value: tString,
-    })),
-    body: tString,
-    isBase64: tBoolean,
+    }))),
+    body: tOptional(tString),
+    isBase64: tOptional(tBoolean),
   });
   scheme.ResponseBodyParams = tOptional(tObject({}));
   scheme.ResponseFinishedParams = tOptional(tObject({}));