chore: fix ansi escaping for diffs #557
Conversation
pavelfeldman
commented
Nov 14, 2024
pavelfeldman
commented
pavelfeldman
force-pushed
the
ansi_fix
branch
from
5a4a82c
to
550610d
Compare
| const isItalic = style['font-style'] === 'italic'; | ||
| if (isItalic) | ||
| token = `<i>${token}</i>`; | ||
| const hasOpacity = style['opacity'] === '0.8'; |
There was a problem hiding this comment.
It is assigned in the line 34, the idea is that we use upstream code for style definition, but then we sanitize it for vscode to accept it.
| const isBold = style['font-weight'] === 'bold'; | ||
| if (isBold) | ||
| token = `<b>${token}</b>`; | ||
| const isItalic = style['font-style'] === 'italic'; |
There was a problem hiding this comment.
Let's have a type for style and also just check if style.italic is true?
There was a problem hiding this comment.
That would fork the code from the upstream a lot.
| const hasOpacity = style['opacity'] === '0.8'; | ||
| if (hasOpacity) | ||
| token = `<span style='color:#666;'>${token}</span>`; | ||
| const color = reverse ? (bg || '#000') : fg; |
There was a problem hiding this comment.
I believe default background will depend on dark/light mode.
There was a problem hiding this comment.
Yeah, I checked it in both modes and it is ok because we only do reverse on mid-light background.
|
|
||
| function escapeHTML(text: string): string { | ||
| return text.replace(/[&"<>\s\n]/g, c => ({ | ||
| ' ': ' ', |
There was a problem hiding this comment.
this won't match other whitespaces, such as \t. Also, do we want to map all whitespaces to non-breaking?
There was a problem hiding this comment.
This has not changed
There was a problem hiding this comment.
hmm, this is what I see upstream:
function escapeHTML(text: string): string {
return text.replace(/[&"<>]/g, c => ({ '&': '&', '"': '"', '<': '<', '>': '>' }[c]!));
}
pavelfeldman
force-pushed
the
ansi_fix
branch
from
550610d
to
050c5c5
Compare
