Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: device emulation #61

Merged
merged 1 commit into from
Jul 1, 2021
Merged

feat: device emulation #61

merged 1 commit into from
Jul 1, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 19, 2021 •
edited
Loading

Add support for devices

@kumaraditya303 kumaraditya303 mentioned this pull request Jun 19, 2021
Closed
5 tasks
@pavelfeldman
Copy link
Member

Let's split this into mypy changes and the actual feature.

mxschmitt
mxschmitt reviewed Jun 28, 2021
View reviewed changes
tests/test_playwright.py Outdated Show resolved Hide resolved
pytest_playwright/pytest_playwright.py Show resolved Hide resolved
@kumaraditya303 kumaraditya303 requested a review from mxschmitt June 30, 2021 07:36
@mxschmitt mxschmitt merged commit c255f95 into microsoft:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@pavelfeldman pavelfeldman Awaiting requested review from pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @pavelfeldman @mxschmitt