fix: make it compatible with unittest.TestCase #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Jun 7, 2021
| def browser_name() -> None: | ||
| return None | ||
| def browser_name(pytestconfig: Any) -> Optional[str]: | ||
| # When using unittest.TestCase it won't use pytest_generate_tests |
There was a problem hiding this comment.
Upstream limitation see under notes: https://pytest.org/en/6.2.x/unittest.html
This was referenced Jun 7, 2021
mxschmitt
force-pushed
the
bugfix/make-compatible-with-unitttest-testcase
branch
from
0ef4559 to
69b6456
Compare
pavelfeldman
reviewed
Jun 7, 2021
| @@ -217,6 +217,30 @@ def context( | |||
|
|
|||
| When using that all pages inside your test are created from the persistent context. | |||
|
|
|||
| ### Using with `unittest.TestCase` | |||
There was a problem hiding this comment.
We could add this into the upstream docs. I think our readme should doc-free...
There was a problem hiding this comment.
Will probably follow up there.
pavelfeldman
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55 (verified)
Fixes #54 (verified)