Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add py.typed file #245

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: add py.typed file #245

merged 1 commit into from
Sep 6, 2024

Conversation

mxschmitt
Copy link
Member

Added a py.typed file to tell mypy (a Python linter) that we are a typed package.

Before we didn't treat

class CreateContextCallback(Protocol):
as part of our public API - but turns our our customers wants to have a typed new_context function which is reasonable.

Is the name CreateContextCallback appropriate? We are still under 0.X releases - so we could rename in theory.

Fixes #244

@mxschmitt mxschmitt merged commit ea833ce into main Sep 6, 2024
16 of 17 checks passed
@mxschmitt mxschmitt deleted the add-py.typed branch September 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use CreateContextCallback in a type hint
2 participants