Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: have correct trace title #157

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: have correct trace title #157

merged 1 commit into from
Mar 17, 2023

Conversation

mxschmitt
Copy link
Member

We want title instead of name.

Fixes #156

@mxschmitt mxschmitt mentioned this pull request Mar 17, 2023
Closed
pavelfeldman
pavelfeldman approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep passing the name too, along with proper tracesDir.

@mxschmitt mxschmitt merged commit d7935c5 into main Mar 17, 2023
@mxschmitt mxschmitt deleted the fix-trace-title branch March 17, 2023 15:47
This was referenced Apr 24, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traces don't contain the test name
2 participants
@mxschmitt @pavelfeldman