Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to overwrite browser_context_args using a marker #146

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

aklajnert
Copy link
Contributor

This is a proposal to make it easier for users to specify the browser_context_args. It has two advantages:

  • user can override a single variable without touching anything else,
  • the built-in browser_context_args has some additional features that are lost when the feature gets overwritten, by using a marker the browser_context_args remains functional.

@aklajnert
Copy link
Contributor Author

@microsoft-github-policy-service agree

@aklajnert aklajnert force-pushed the specify_context_args branch from 95fbfc4 to e095d23 Compare January 27, 2023 08:55
@aklajnert aklajnert changed the title Allow user to overwrite browser_context_args for a single test. Allow user to overwrite browser_context_args using a marker Jan 27, 2023
@mxschmitt mxschmitt merged commit 72fd3f5 into microsoft:main Jun 19, 2023
@aklajnert aklajnert deleted the specify_context_args branch June 20, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants