Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dataset] added collection validator #83

Merged
merged 8 commits into from
Feb 28, 2023

Conversation

TomAugspurger
Copy link
Contributor

This adds a pctasks dataset validate-collection command to verify that collection templates meet our requirements.

I verified that our existing datasets pass.

ls -1 datasets/**/*/template.json | xargs -I {} pctasks dataset validate-collection {}

Tom Augspurger added 3 commits November 10, 2022 11:08
This adds a `pctasks dataset validate-collection` command
to verify that collection templates meet our requirements.

I verified that our existing datasets pass.

```
ls -1 datasets/**/*/template.json | xargs -I {} pctasks dataset validate-collection {}
```
(cherry picked from commit 37ae652)
@TomAugspurger
Copy link
Contributor Author

I want to get this into CI to validate collections. I'm currently having trouble with the output getting swallowed when called through the CLI.

@TomAugspurger
Copy link
Contributor Author

Example failure at https://github.com/microsoft/planetary-computer-tasks/actions/runs/4294990455/jobs/7484783839#step:7:62

Errors in collection usda-cdl at datasets/usda-cdl/collection/template.json
  must have license link
Error: Invalid collection: usda-cdl
Error: Process completed with exit code 123.

@TomAugspurger TomAugspurger merged commit 8a0350c into main Feb 28, 2023
@TomAugspurger TomAugspurger deleted the tom/feature/collection-validator branch February 28, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant