[dataset]: Include since in the workflow paths
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, our dynamic pipelines using `--is-update-workflow` will
reuse the same prefix for chunkfiles. This might result in the assets or
ndjson files being overwritten by subsequent pipeline runs.
This PR updates the `--is-update-workflow` path to inject the
``${{since}}` argument into the path used by the chunkfiles.
TomAugspurger
commented
Jul 11, 2023
TomAugspurger
force-pushed
the
tom/fix/update-workflow-paths
branch
from
73e9d59 to
cdffac9
Compare
lossyrob
reviewed
Jul 11, 2023
lossyrob
reviewed
Jul 11, 2023
added 2 commits
July 11, 2023 14:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our dynamic pipelines using
--is-update-workflowwill reuse the same prefix for chunkfiles. This might result in the assets or ndjson files being overwritten by subsequent pipeline runs.This PR updates the
--is-update-workflowpath to inject the ``${{since}}` argument into the path used by the chunkfiles.