Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate goes-cmi #214

Merged
merged 4 commits into from
Jul 6, 2023
Merged

migrate goes-cmi #214

merged 4 commits into from
Jul 6, 2023

Conversation

pjhartzell
Copy link
Contributor

@pjhartzell pjhartzell commented Jun 13, 2023

Description

Adds the goes-cmi Collection.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Created goes-cmi Items via pctasks.
    • I am unable to ingest Items into PC Test. I deleted the goes-cmi Items and the Collection from PC Test. But am running into a known pgstac issue where ingesting a Collection after deleting a Collection with the same id causes Item ingest to fail.
  • Checked for equivalence to production Items by diffing an Item from the production API against one produced with this PR.

Notes:

  • Ran isort and black against the Python files. Note that scripts/format does not touch files in the datasets directory.
  • Docker image built and pushed to both pccomponents and pccomponentstest registries.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@pjhartzell pjhartzell requested a review from TomAugspurger June 13, 2023 18:59
@pjhartzell pjhartzell force-pushed the pjh/feature/goes-cmi branch from 675e5ba to 7a34629 Compare June 13, 2023 19:01
@pjhartzell pjhartzell self-assigned this Jun 14, 2023
@pjhartzell pjhartzell marked this pull request as draft June 16, 2023 12:42
@pjhartzell pjhartzell force-pushed the pjh/feature/goes-cmi branch from a395ec1 to 79ccfe8 Compare June 21, 2023 17:42
@pjhartzell pjhartzell marked this pull request as ready for review June 21, 2023 17:42
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TomAugspurger TomAugspurger merged commit 8409400 into main Jul 6, 2023
@TomAugspurger TomAugspurger deleted the pjh/feature/goes-cmi branch July 6, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants