Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate GBIF from etl #211

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Migrate GBIF from etl #211

merged 4 commits into from
Jun 12, 2023

Conversation

pjhartzell
Copy link
Contributor

Description

Adds the Global Biodiversity Information Facility (GBIF) dataset.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Created and ingested all 25 Items into PC Test
  • Checked for equivalence to production Items by diffing an Item from the production API against one produced with this PR.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@pjhartzell pjhartzell changed the title feat: add gbif Migrate GBIF from etl May 31, 2023
TomAugspurger
TomAugspurger approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM.

datasets/gbif/requirements.txt Outdated Show resolved Hide resolved
@pjhartzell pjhartzell requested a review from TomAugspurger June 7, 2023 20:12
TomAugspurger
TomAugspurger reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TomAugspurger TomAugspurger merged commit c50f2fb into main Jun 12, 2023
@TomAugspurger TomAugspurger deleted the pjh/feature/gbif branch June 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees

@pjhartzell pjhartzell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjhartzell @TomAugspurger