[core]: Avoid PyZipFile in code upload #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2023 15:54
This reimplements code upload for directories to avoid PyZipFile.writepy. It (deliberately) uploads `.pyc` files, which imposes a strong constraint that the version of Python running submit on the client matches the version of Python running in the task. Instead, we replicate PyZipFile.writepy's behavior, but we upload `.py` files rather than `.pyc`. The zip-based importer works with both `.py` and `.pyc` files.
TomAugspurger
force-pushed
the
tom/fix/pyzipfile
branch
from
6779b08 to
1f8697f
Compare
|
I've tested this out manually over on the sentinel-3 branch (where I'm using a different minor version of python to submit a directory of files) and things are working well. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements code upload for directories to avoid PyZipFile.writepy. It (deliberately) uploads
.pycfiles, which imposes a strong constraint that the version of Python running submit on the client matches the version of Python running in the task.Instead, we replicate PyZipFile.writepy's behavior, but we upload
.pyfiles rather than.pyc. The zip-based importer works with both.pyand.pycfiles.