Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]: Add helper to rewrite blob storage urls #168

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Apr 7, 2023

Description

In the low-latency branch, EventGrid gives us urls like https://<account>.blob.core.windows.net/<container>/<path>. The create items function expect blob://<account>/<container>/<path> URLs. This function implements that.

I didn't see this implemented anywhere, but I might have missed it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@TomAugspurger TomAugspurger requested a review from lossyrob April 7, 2023 19:03
In the low-latency branch, EventGrid gives us urls like
`https://<account>.blob.core.windows.net/<container>/<path>`. The create
items function expect `blob://<account>/<container>/<path>` URLs. This
function implements that.
@TomAugspurger TomAugspurger force-pushed the tom/feature/rewrite-blob-url branch from bdd60c3 to 8abc9ae Compare April 7, 2023 20:46
@TomAugspurger TomAugspurger merged commit 2acf9a6 into main Apr 13, 2023
@TomAugspurger TomAugspurger deleted the tom/feature/rewrite-blob-url branch April 13, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants