Use service principal in deployment #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossyrob
commented
Mar 7, 2023
| @@ -100,31 +100,6 @@ module "batch_pool_d3_v2_landsat" { | |||
| subnet_id = module.resources.batch_nodepool_subnet | |||
| } | |||
|
|
|||
| module "batch_pool_d3_v3_modis" { | |||
There was a problem hiding this comment.
Also removing unused batch pool that had been deleted from the batch account manually.
TomAugspurger
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changes to using a federated identity, as that method hasn't been working for our CI deploy. Mounting
the ~/.azure directory into the container did not work
for containerized deployment. We'll continue to use
a service principal for this.