Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kv access settings #153

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

gregoriomartin
Copy link
Contributor

@gregoriomartin gregoriomartin commented Mar 7, 2023

Description

To disable public access to the KV of the pc-tasks, the kv terraform script was modified to only permit connections from trusted services, allowlisted IP addresses, and the vnet of the k8s nodes.

Fixes # (issue)

Compliance security of the pc tasks kvs

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review

@lossyrob lossyrob merged commit 9fcfcdb into microsoft:main Mar 8, 2023
@gregoriomartin gregoriomartin deleted the change-kv-access branch March 8, 2023 18:31
lossyrob added a commit that referenced this pull request Mar 9, 2023
lossyrob added a commit that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants