-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Function App which runs periodically to aggregate the bytes read per IP address over a window of time #215
Merged
elayrocks
merged 46 commits into
main
from
user/elay/add-function-app-to-generate-banned-ip
Jun 26, 2024
Merged
Azure Function App which runs periodically to aggregate the bytes read per IP address over a window of time #215
elayrocks
merged 46 commits into
main
from
user/elay/add-function-app-to-generate-banned-ip
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcfarland
reviewed
Jun 11, 2024
mmcfarland
reviewed
Jun 24, 2024
mmcfarland
approved these changes
Jun 26, 2024
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first step in implementing data consumption quotas for SAS API Token Issuance. I created a new Azure Function App which runs periodically to execute a KQL query against Storage Account Blob Logs to aggregate the bytes read per IP address over a window of time (e.g., 24 hours). IPs which have read above a certain threshold will be added to an Azure storage table called
blob storage banned ip
which serves as a temporary ban list.Please refer to the design doc for more details.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit test uses mocked response from log query client and writes test data to azurite. The integration/E2E test queries the log analytics workspace and writes to test table in storage account and deletes it after testing is complete.
Make sure correct roles have been assigned, run
./scripts/server
to start azurite service andscripts/test --funcs [--no-integration]
to run unit tests. and integration tests (optionally).Checklist:
Please delete options that are not relevant.