Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Alert manager] k8s cert expiration checker #5409

Merged
merged 38 commits into from
Apr 9, 2021

Conversation

yiyione
Copy link
Contributor

@yiyione yiyione commented Apr 1, 2021

@yiyione yiyione requested review from Binyang2014 and suiguoxin and removed request for Binyang2014 April 1, 2021 12:30
@yiyione yiyione marked this pull request as ready for review April 1, 2021 12:30
@suiguoxin
Copy link
Member

Could you provide some documents to the end of this file : https://github.com/microsoft/pai/blob/master/docs/manual/cluster-admin/how-to-use-alert-system.md

@yiyione
Copy link
Contributor Author

yiyione commented Apr 8, 2021

Could you provide some documents to the end of this file : https://github.com/microsoft/pai/blob/master/docs/manual/cluster-admin/how-to-use-alert-system.md

Added.

@yiyione yiyione merged commit 4cc1e90 into master Apr 9, 2021
@yiyione yiyione deleted the yiyi/alert-manager/cert-expiration-checker branch April 9, 2021 03:15
@siaimes
Copy link
Contributor

siaimes commented Apr 20, 2021

Could you provide some documents to the end of this file : https://github.com/microsoft/pai/blob/master/docs/manual/cluster-admin/how-to-use-alert-system.md

Added.

This feature will be enable by default, if the action email-admin is enabled.
You can configure the alert-manager->cert-expiration-checker field in services-configuration.yml.
schedule, alert-residual-days and cert-path are necessary fields for this feature, and we have default value for the fields.

Hi, @yiyione

I have some doubts about this description. Is the warning message not sent to the upper right corner of the homepage? If the warning message is sent to the upper right corner of the homepage, can I use this feature without setting up a mail server?

Thanks.

@siaimes
Copy link
Contributor

siaimes commented Apr 22, 2021

kubernetes/kubernetes/pull/52196

In addition, I found a PR in the kubernetes repository that seems to fix the problem. Is this PR in this repository still necessary?

@Binyang2014
Copy link
Contributor

@siaimes Nice catch! We don't notice this feature. For this release, we will still use this PR. After we verified this feature, this PR can revert. Thanks for this notice!

@yiyione
Copy link
Contributor Author

yiyione commented Apr 23, 2021

Hi, @yiyione

I have some doubts about this description. Is the warning message not sent to the upper right corner of the homepage? If the warning message is sent to the upper right corner of the homepage, can I use this feature without setting up a mail server?

Thanks.

It's a good question, and we are going to fix it.
After the PR #5440 merged, the admin will be able to view the alert on the upper right corner of the homepage without setting up the email.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants