This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
add 'enflame.com/dtu' to rest-server #5139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abuccts
suggested changes
Dec 2, 2020
Comment on lines
+487
to
+488
| 'enflame.com/dtu': | ||
| config.taskRoles[taskRole].resourcePerInstance.gpu, |
There was a problem hiding this comment.
what is this for? could you include a clear and detailed description explaining the reasons for the changes?
There was a problem hiding this comment.
enflame DTU(Deep Thinking Unit) is the AI process card from enflame.
With help of enflame k8s device plugin, the DTUs in worker nodes can be detected and allocated by K8S.
This commit adds the 'enflame.com/dtu' as another GPU resource to OpenPAI.
4 tasks
abuccts
suggested changes
Dec 2, 2020
| @@ -484,6 +484,8 @@ const generateTaskRole = ( | |||
| 'github.com/fuse': 1, | |||
| 'nvidia.com/gpu': | |||
| config.taskRoles[taskRole].resourcePerInstance.gpu, | |||
| 'enflame.com/dtu': | |||
There was a problem hiding this comment.
- we don't have such card to test or use
- this pr won't work and it will break all nodes
pls feel free to keep a fork to support your new card, and pls do test your code before submitting a pr
|
Close this. Related issues & PRs are tracked in #5138 now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.