Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

fix wrong framework retry records #4915

Merged
merged 3 commits into from
Sep 21, 2020
Merged

fix wrong framework retry records #4915

merged 3 commits into from
Sep 21, 2020

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Sep 18, 2020

to fix #4911

fix

fix

fix

fix

fix

fix

fix
@hzy46 hzy46 requested a review from yqwang-ms September 18, 2020 08:42
@hzy46
Copy link
Contributor Author

hzy46 commented Sep 18, 2020

Test result (use the same config as in #4911)

image

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage remained the same at 34.801% when pulling b46460c on zhiyuhe/add_fluentd_logtype into d99ca9e on master.

<record>
logType "${\
if record['logMessage'].include? 'enqueueFrameworkObj: Framework Pod Deleted'
'deleted_pod_snapshot'
Copy link
Member

@yqwang-ms yqwang-ms Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted_pod_snapshot [](start = 13, length = 20)

pod_deleted #Closed

if record['logMessage'].include? 'enqueueFrameworkObj: Framework Pod Deleted'
'deleted_pod_snapshot'
elsif record['logMessage'].include? 'syncFrameworkState: Framework will be retried'
'retried_framework_snapshot'
Copy link
Member

@yqwang-ms yqwang-ms Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retried_framework_snapshot [](start = 13, length = 26)

framework_retried #Closed

elsif record['logMessage'].include? 'syncFrameworkState: Framework will be retried'
'retried_framework_snapshot'
elsif record['logMessage'].include? 'syncTaskState: Task will be retried'
'task_retried_framework_snapshot'
Copy link
Member

@yqwang-ms yqwang-ms Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task_retried_framework_snapshot [](start = 13, length = 31)

task_retried #Closed

enable_ruby
<record>
logType "${\
if record['logMessage'].include? 'enqueueFrameworkObj: Framework Pod Deleted'
Copy link
Member

@yqwang-ms yqwang-ms Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'enqueueFrameworkObj: Framework Pod Deleted [](start = 43, length = 43)

'Framework Pod Deleted' #Closed

logType "${\
if record['logMessage'].include? 'enqueueFrameworkObj: Framework Pod Deleted'
'deleted_pod_snapshot'
elsif record['logMessage'].include? 'syncFrameworkState: Framework will be retried'
Copy link
Member

@yqwang-ms yqwang-ms Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Framework will be retried' [](start = 67, length = 26)

'Framework will be retried' #Closed

'deleted_pod_snapshot'
elsif record['logMessage'].include? 'syncFrameworkState: Framework will be retried'
'retried_framework_snapshot'
elsif record['logMessage'].include? 'syncTaskState: Task will be retried'
Copy link
Member

@yqwang-ms yqwang-ms Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task will be retried' [](start = 62, length = 21)

'Task will be retried'
#Closed

@@ -94,6 +94,24 @@ data:
</record>
</filter>

# add logType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logType [](start = 10, length = 7)

objectSnapshotTrigger

Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hzy46 hzy46 merged commit f5552de into master Sep 21, 2020
@hzy46 hzy46 deleted the zhiyuhe/add_fluentd_logtype branch October 5, 2020 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task retry will cause wrong framework retry records
3 participants